-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg-config: Use --libs --static when building with using --enable-executable-static #6935
base: master
Are you sure you want to change the base?
Conversation
196eed4
to
5263473
Compare
5263473
to
5969a91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a test, or at the very least an issue which describes what this fixes (i.e. some test plan).
5969a91
to
23a4daa
Compare
@nh2 does this look good? If you say so, I'll merge this without requiring a test case |
The motion is great, and I want and need this, but I think what's in this PR is not enough to make it work well. I already did most of this work in the past, please read nh2/static-haskell-nix#62. Key important part:
This requires Cabal changes (which I provide in 2 branches, linked from there), and a GHC change (which I got blocked on because of Hadrian bugs). I think the right way to do this is to fix Hadrian (I already provided a WIP GHC PR, linked, but then ran out of time for now), and then do the GHC side and rebase the Cabal patches. I'd be happy to advise on those topics if you'd like to do it @alexbiehl because i'm currently too busy to finish it myself. |
Great! I lam willing to take this on. It will take a while as I am on vacations though. So feel free to take this up again in the meantime. I will leave a note when I start working on it actively. |
@alexbiehl any plans to return to this? |
Hi! Thanks for the gentle reminder. I lost track of this but static linking is still near and dear to my heart and would love to get this done. I have put this on my backlog for tue weekend to evaluate and see what’s left to do. |
Oh, great news. In case it matters, here's a probably superficially related newer issue not yet mentioned in pingbacks above: #7236, |
@alexbiehl would you like my help with fixing the conflicts of your PR? |
@Kleidukos sure! Feel free to to resolve and push! |
23a4daa
to
52811c0
Compare
6b3621b
to
1adc67a
Compare
1adc67a
to
39ff0f1
Compare
@Kleidukos: I have an impression the actual change got literally lost while formatting. If I'm mistaken, Could you point out what the original change has been? Ideally, it'd be in a commit separate from the formatting changes. |
I remove needs-review for now because it currently needs some love (see Mikolaj's comment above).. |
When
--enable-executable-static
is enabled Cabal passes--static
to pkg-config to obtain linker flags for static linking.Please include the following checklist in your PR:
changelog.d
directory).Please also shortly describe how you tested your change. Bonus points for added tests!